Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle versions being given to the scheduled workflows for testing on AKS and EKS. #1122

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Oct 22, 2024

Closes #1119.

This PR updates the "Deploy to AKS" and "Deploy to EKS" actions to properly receive the bundle versions when running on schedule.

We have implemented this idea from @DnPlas. Note that I have made a slight modification: I assume that we don't want to test unsupported versions (1.7 at the moment of writing), so I am including a TARGET_VERSIONS variable that includes the versions we do want to test

@mvlassis mvlassis requested a review from a team as a code owner October 22, 2024 14:23
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, left 2 comments

.github/workflows/deploy-to-aks.yaml Outdated Show resolved Hide resolved
scripts/gh-actions/parse_versions.py Outdated Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a last comment

ye
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled AKS and EKS ci doesn't work due to empty version
2 participants