Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build page on /solutions/cloud-native-development #1577

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented Feb 26, 2025

Done

  • Build page on /solutions/cloud-native-development
  • Build a get in touch modal

QA

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-19255

@webteam-app
Copy link

@minkyngkm
Copy link
Contributor Author

Hi @kim-isaac and @eliman11, this PR is ready for UX and design review. Please feel free to take a look at the demo when you are available. Thanks!

@kim-isaac
Copy link

kim-isaac commented Feb 26, 2025

Thanks @minkyngkm, I have some comments below:
You can check full comments on Figma.
Screenshot 2025-02-26 at 17 52 46

  • As I mentioned in Jira, this part should be hidden for now.

Screenshot 2025-02-26 at 17 54 25

  • For this part, could we use 2-4 column instead of 3-3?

-For tablet size

Screenshot 2025-02-26 at 17 55 54

  • For all blue highlighted sections(let us... / deply.../run your.../one subscription.../choose your...); could we use 50:50 with image like this telco/open-ran page?

-For mobile

Screenshot 2025-02-26 at 17 59 47

  • (seems like)Image container didn’t fully removed here, making additional margin. Could you remove it?
    (from this to next section)
  • Also, can we skip 24px bottom margin like ‘Choose your app modernization journey’ section?
    (from this to ‘One subscription. No surprises.’ section)

Screenshot 2025-02-26 at 18 00 44

  • For all quote sections, could you remove bottom margin? (example below)

Thanks again and let me know if you have any questions!

@eliman11
Copy link
Collaborator

eliman11 commented Feb 26, 2025

Thanks @minkyngkm, this looks great! Some comments from me:

Screenshot 2025-02-26 at 16 47 36

@minkyngkm
Copy link
Contributor Author

Thanks @kim-isaac and @eliman11 for reviewing. I've addressed all your comments. Hopefully it looks better now! https://canonical-com-1577.demos.haus/solutions/cloud-native-development

@kim-isaac
Copy link

kim-isaac commented Feb 27, 2025

Thanks for addressing things @minkyngkm , It looks great! A few comments left for tablet size:
Screenshot 2025-02-27 at 15 14 39

  • Could we have the images also for Tablet?

Screenshot 2025-02-27 at 15 16 17

  • Could you make this a 50:50 layout as well?

That's all from visual side, thanks again!

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (08d9243) to head (e124827).
Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1577   +/-   ##
=======================================
  Coverage   71.85%   71.86%           
=======================================
  Files          17       17           
  Lines        1464     1468    +4     
=======================================
+ Hits         1052     1055    +3     
- Misses        412      413    +1     
Flag Coverage Δ
python 71.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minkyngkm
Copy link
Contributor Author

@kim-isaac
Copy link

@minkyngkm Thanks for arranging these super quickly! I’ll add +1

tab.addEventListener("click", function (event) {
event.preventDefault();

document.querySelectorAll(".p-tabs__link").forEach((t) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed to make the querySelectorAll a second time here?

@@ -309,3 +309,26 @@ function getCustomFields(event) {
const textarea = document.getElementById("Comments_from_lead__c");
textarea.value = message;
}

// Fix Tab and modal js conflicts
(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked into it, but would it be possible to add a check to the initial 'aria-controls' listener for forms to see if it has an associated form (with document.getElementById(targetControls)) before calling toggleModal, so it doesn't affect other elements with aria-controls?

@minkyngkm minkyngkm merged commit 8ab1006 into canonical:main Mar 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants