-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build page on /solutions/cloud-native-development #1577
Conversation
Hi @kim-isaac and @eliman11, this PR is ready for UX and design review. Please feel free to take a look at the demo when you are available. Thanks! |
Thanks @minkyngkm, I have some comments below:
-For tablet size
-For mobile
Thanks again and let me know if you have any questions! |
Thanks @minkyngkm, this looks great! Some comments from me:
![]() |
Thanks @kim-isaac and @eliman11 for reviewing. I've addressed all your comments. Hopefully it looks better now! https://canonical-com-1577.demos.haus/solutions/cloud-native-development |
Thanks for addressing things @minkyngkm , It looks great! A few comments left for tablet size:
That's all from visual side, thanks again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
Coverage 71.85% 71.86%
=======================================
Files 17 17
Lines 1464 1468 +4
=======================================
+ Hits 1052 1055 +3
- Misses 412 413 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@minkyngkm Thanks for arranging these super quickly! I’ll add +1 |
tab.addEventListener("click", function (event) { | ||
event.preventDefault(); | ||
|
||
document.querySelectorAll(".p-tabs__link").forEach((t) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed to make the querySelectorAll
a second time here?
@@ -309,3 +309,26 @@ function getCustomFields(event) { | |||
const textarea = document.getElementById("Comments_from_lead__c"); | |||
textarea.value = message; | |||
} | |||
|
|||
// Fix Tab and modal js conflicts | |||
(function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked into it, but would it be possible to add a check to the initial 'aria-controls' listener for forms to see if it has an associated form (with document.getElementById(targetControls)
) before calling toggleModal
, so it doesn't affect other elements with aria-controls?
Done
/solutions/cloud-native-development
QA
Issue / Card
Fixes #https://warthogs.atlassian.net/browse/WD-19255