-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'Allainces' to careers section #1588
base: main
Are you sure you want to change the base?
Conversation
@Sophie-32 There are a couple inconsistencies with the naming of 'alliance and channels' and 'alliance & channels' in the doc/figma. As these are pulled from the back end, we will have to choose one to use |
Thanks @petesfrench ! Comments are below: Landing page: For the hero:
For "Departments:
For "Our Mission":
For "Working here":
/alliances-and-channels For the hero (ty for seeing Lyubo's comment and removing padding top btw): For "features roles":
|
@mattea-turic Thanks for the review, a couple questions/notes:
The logo looks a little off when the background isn't white, as one hand has a white background. Is this ok? As this section uses a re-usable template, these changes will be applied to all careers pages. Is that ok? |
Ah makes sense, thanks!
I added another one with a paper background. Would it be possible to switch between the two depending on breakpoint?
|
It is possible, but not practical. Could you remove the background entirely on it? |
If you take a look at the svg, I'm able to do it for the main part of the hand, but the fingers are designed in a way that make it look off if I'm to make the line adjustments for it to w/o the bg: ![]() It's small, so might not be obvious to most people but I worry about it looking sloppy if someone were to inspect it deeper; but let's try it anyways: |
|
LGTM, thanks @petesfrench ! |
Done
_canonical_navigation.html
as it doesn't appear to be used anywhereQA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-19294