Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify product description #11

Closed
wants to merge 12 commits into from
Closed

Conversation

solmyrcan
Copy link
Contributor

Description

This PR includes some modifications to the description text for Charmed Aether SD-Core, and some minor text modifications as proposed improvements.

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • [x ] I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@solmyrcan solmyrcan requested a review from a team as a code owner April 30, 2024 18:11
@markbeierl markbeierl changed the title Telco 1146 doc updates chore: Telco 1146 doc updates Apr 30, 2024
Copy link
Contributor

@markbeierl markbeierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks!

@markbeierl
Copy link
Contributor

But it looks like your commits were not signed. We will have to go back and sign them.

Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update the PR title (which will end up being the commit message) so that it reflects what the update is. doc update is too generic and can be applied to any change in this project. Also, no need to place the Jira ticket id.
  • Please sign your commits

@solmyrcan solmyrcan changed the title chore: Telco 1146 doc updates chore: modify product description May 6, 2024
@markbeierl markbeierl requested a review from gruyaume May 6, 2024 10:34
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many unsigned commits will prevent merging this. Please either sign the old commits or squash them into a new signed one.

@solmyrcan
Copy link
Contributor Author

I have squashed the commits now and signature is in place. Please kindly review.

@solmyrcan solmyrcan requested a review from gruyaume May 10, 2024 11:56
@gruyaume
Copy link
Collaborator

gruyaume commented May 12, 2024

I have squashed the commits now and signature is in place. Please kindly review.

On the commits tab, you will see Verified next to signed commits. As as you can see, there are 11 commits in this PR, and 4 of them are not signed. All the commits need to be signed in order to be able to merge PR's.

image

To squash your commits into one, you can run the following from your branch:

git reset --soft HEAD~<num of commits>
git commit -S -m <your commit message"
git push --force

Here would be 11, and your commit message can be the same as your PR description chore: modify product description.

Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note on how to squash and sign commits, this is a pre-requisite to merging this.

@solmyrcan
Copy link
Contributor Author

Closing this pull request, as PR#16 is the new and clean one.

@solmyrcan solmyrcan closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants