-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modify product description #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, thanks!
But it looks like your commits were not signed. We will have to go back and sign them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please update the PR title (which will end up being the commit message) so that it reflects what the update is.
doc update
is too generic and can be applied to any change in this project. Also, no need to place the Jira ticket id. - Please sign your commits
…-aether-sd-core into TELCO-1146_doc-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many unsigned commits will prevent merging this. Please either sign the old commits or squash them into a new signed one.
…-aether-sd-core into TELCO-1146_doc-updates
I have squashed the commits now and signature is in place. Please kindly review. |
On the commits tab, you will see To squash your commits into one, you can run the following from your branch:
Here would be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a note on how to squash and sign commits, this is a pre-requisite to merging this.
Closing this pull request, as PR#16 is the new and clean one. |
Description
This PR includes some modifications to the description text for Charmed Aether SD-Core, and some minor text modifications as proposed improvements.
Checklist: