Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace domain from .mgmt to .mgmt.local #97

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Feb 20, 2025

Description

Here, we replace .mgmt with .mgmt.local. This change is required because of a recent change in the webconsole where we do input validation on the upf hostname and .mgmt is not a valid domain.

This PR partly addresses the issue identified here:

Checklist:

  • Documentation follows the Canonical Documentation Style Guide
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Signed-off-by: Guillaume Belanger <[email protected]>
@gruyaume gruyaume requested a review from a team as a code owner February 20, 2025 15:59
Signed-off-by: Guillaume Belanger <[email protected]>
@gruyaume gruyaume changed the title chore: use correct fqdn for upf chore: replace domain from .mgmt to .mgmt.local Feb 20, 2025
@gruyaume gruyaume merged commit 6cd1dc9 into main Feb 20, 2025
7 checks passed
@gruyaume gruyaume deleted the dev-upfmgmt branch February 20, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants