Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updates deploy_sdcore_cups.md #99

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore: Updates deploy_sdcore_cups.md #99

merged 1 commit into from
Feb 28, 2025

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Feb 27, 2025 •
edited
Loading

Description

This PR addresses comments from #88. It also updates the TF snippets to match the official modules.

Checklist:

  • Documentation follows the Canonical Documentation Style Guide
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner February 27, 2025 11:30
@Gmerold Gmerold merged commit f80cb08 into main Feb 28, 2025
8 checks passed
@Gmerold Gmerold deleted the TELCO-1599-update-deploy-cups branch February 28, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciareinoso patriciareinoso patriciareinoso approved these changes

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gmerold @patriciareinoso @ghislainbourgeois