Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add kfp_v2 notebook for testing v2 pipelines #53

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Nov 21, 2023

This commit ensures we have enough coverage for testing pipelines using the v2 SDK.

Please note that I have separated v1 and v2 notebooks into their own folders to make it clear which version of the pipeline and SDK is been used during test exection.

This Notebook is based on the condition Kubeflow pipelines example.

This commit ensures we have enough coverage for testing pipelines using the v2 SDK.
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests LGTM, just a small comment: the notebook names need to be unique for the driver to pick up both of them.
I suggest we change them to kfp-v1-integration.ipynb and kfp-v2-integration.ipynb.

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@orfeas-k orfeas-k merged commit 1501559 into main Nov 22, 2023
1 check passed
@orfeas-k orfeas-k deleted the KF-4993-add-v2-pipelines-nb branch November 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants