Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: training-integration uat by updating image #68

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: training-integration uat by updating image #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd99a83
fix: training-integration uat by updating image
orfeas-k Jun 11, 2024
de5e91c
review: update
orfeas-k Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions tests/notebooks/training/training-integration.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@
"source": [
"# Test Training Operator Integration\n",
"\n",
"This example notebook is loosely based on [this](https://github.com/kubeflow/training-operator/blob/master/sdk/python/examples/kubeflow-tfjob-sdk.ipynb) upstream example.\n",
"This example notebook is loosely based on the following upstream examples:\n",
"* [TFJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/tensorflow/image-classification/create-tfjob.ipynb)\n",
DnPlas marked this conversation as resolved.
Show resolved Hide resolved
"* [PyTorchJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/pytorch/image-classification/create-pytorchjob.ipynb)\n",
"* [PaddleJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/paddlepaddle/simple-cpu.yaml)\n",
"\n",
"- create training job of type: TFJob, PyTorchJob, and PaddleJob\n",
"Note that the above can get out of sync with the actual testing upstream does, so make sure to also check out [upstream E2E tests](https://github.com/kubeflow/training-operator/tree/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/sdk/python/test/e2e) for updating the notebook.\n",
"\n",
"The workflow for each job (TFJob, PyTorchJob, and PaddleJob) is:\n",
"- create training job\n",
"- monitor its execution\n",
"- get training logs\n",
"- delete job"
Expand Down Expand Up @@ -142,7 +148,7 @@
"source": [
"### Define a TFJob\n",
"\n",
"Define a TFJob object before deploying it. This TFJob is similar to [this](https://github.com/kubeflow/training-operator/blob/master/sdk/python/examples/kubeflow-tfjob-sdk.ipynb) example."
"Define a TFJob object before deploying it."
]
},
{
Expand Down Expand Up @@ -411,7 +417,8 @@
"source": [
"PYTORCHJOB_NAME = \"pytorch-dist-mnist-gloo\"\n",
"PYTORCHJOB_CONTAINER = \"pytorch\"\n",
"PYTORCHJOB_IMAGE = \"gcr.io/kubeflow-ci/pytorch-dist-mnist-test:v1.0\""
"PYTORCHJOB_IMAGE = \"kubeflow/pytorch-dist-mnist:v1-3a360ba\"\n",
"# The image above should be updated with each release with the latest available in the registry."
]
},
{
Expand Down Expand Up @@ -633,7 +640,7 @@
"source": [
"### Define a PaddleJob\n",
"\n",
"Define a PaddleJob object before deploying it. This PaddleJob is loosely based on [this](https://github.com/kubeflow/training-operator/blob/11b7a115e6538caeab405344af98f0d5b42a4c96/examples/paddlepaddle/simple-cpu.yaml) example."
"Define a PaddleJob object before deploying it."
]
},
{
Expand All @@ -644,7 +651,7 @@
"source": [
"PADDLEJOB_NAME = \"paddle-simple-cpu\"\n",
"PADDLEJOB_CONTAINER = \"paddle\"\n",
"PADDLEJOB_IMAGE = \"registry.baidubce.com/paddlepaddle/paddle:2.4.0rc0-cpu\""
"PADDLEJOB_IMAGE = \"docker.io/paddlepaddle/paddle:2.4.0rc0-cpu\""
]
},
{
Expand Down