Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show digest for OCI images in resources tab #1973

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat: show digest for OCI images in resources tab #1973

merged 1 commit into from
Aug 16, 2024

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Aug 15, 2024

Done

  • Show digest for OCI images in resources tab. This can be useful to know what the actual resource is since it can be cross reference with the docker registry.

How to QA

  • go to /charm/resources
  • If resource is an oci image, short digest should be displayed.

Testing

  • This PR has tests
  • No testing required (explain why): no new logic

Issue / Card

Partially addresses #1548, Although this is a larger UX issue

@webteam-app
Copy link

Demo

Jenkins

demos.haus

abbiesims
abbiesims approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@M7mdisk M7mdisk merged commit 24401a2 into main Aug 16, 2024
9 checks passed
@M7mdisk M7mdisk deleted the WD-14196-add-resource-digest-to-resources-table-on-charmhub-io branch August 16, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiesims abbiesims abbiesims approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M7mdisk @webteam-app @abbiesims