feat(24.04) add slice for crun and uidmap #225
Conversation
|
Diff of dependencies: |
endersonmaia
force-pushed
the
crun-to-24.04
branch
from
0bee945 to
2fc6357
Compare
endersonmaia
force-pushed
the
crun-to-24.04
branch
from
2fc6357 to
450bfb9
Compare
endersonmaia
force-pushed
the
crun-to-24.04
branch
from
450bfb9 to
a7162d3
Compare
endersonmaia
force-pushed
the
crun-to-24.04
branch
from
a7162d3 to
0078313
Compare
|
@cjdcordeiro @rebornplusplus can you approve the ci workflow please? |
fix yamllint errors
add copyright slice
sort essential
endersonmaia
force-pushed
the
crun-to-24.04
branch
from
46eba25 to
239397e
Compare
There was a problem hiding this comment.
thanks for this @endersonmaia !
I think it's almost there. Apart from debconf everything else is just trivial comments
slices/debconf.yaml
Outdated
| contents: | ||
| /usr/share/debconf/confmodule: | ||
| /usr/share/debconf/confmodule.sh: | ||
| /usr/share/debconf/debconf.conf: |
There was a problem hiding this comment.
isn't this also a config file?
slices/debconf.yaml
Outdated
| /usr/share/debconf/confmodule: | ||
| /usr/share/debconf/confmodule.sh: |
There was a problem hiding this comment.
these aren't perl modules. the first is actually run during the maintainer scripts.
There was a problem hiding this comment.
maybe it's ok to have them here, but I'd like to ask you to double check is 1) you really need them (cause if they are only used for the maintainer scripts, then they are not needed) and 2) if needed, try to reassess if they fit within this modules slice
There was a problem hiding this comment.
I may note be the best person to check this, I have no knowledge in the packing internals.
slices/debconf.yaml
Outdated
| /usr/share/debconf/confmodule.sh: | ||
| /usr/share/debconf/debconf.conf: | ||
| /usr/share/debconf/fix_db.pl: | ||
| /usr/share/debconf/frontend: |
There was a problem hiding this comment.
although a script, this is also considered an interface configuration file, as it is used to configure the frontend. it is not a module. can u pls move it to another slice?
slices/debconf.yaml
Outdated
| /usr/share/debconf/confmodule: | ||
| /usr/share/debconf/confmodule.sh: | ||
| /usr/share/debconf/debconf.conf: | ||
| /usr/share/debconf/fix_db.pl: |
There was a problem hiding this comment.
This is a standalone script. I guess you might not always need it. I suggest moving it to a separate slice
slices/libpam0g.yaml
Outdated
There was a problem hiding this comment.
is the debconf-2.0 dependency left out on purpose?
There was a problem hiding this comment.
I understand they conflict, you'd have to choose one or the other, but again, I don't understand the debian packaging details, I'm just trying to build a small image and sharing what I've done upstream. 😓
cjdcordeiro
requested review from
zhijie-yang and
linostar
and removed request for
linostar and
zhijie-yang
Co-authored-by: Cristovao Cordeiro <[email protected]>
|
Could live without debconf for a chiselled environment? 😓 I mean, after you install all packages into a "chiselled" environment, you won't be using apt/dev anymore, right? |
That would be my gut feeling as well. I sympathize with the struggle here. My advice is: remove everything that is not needed for your use case to work. It's much easier to add additional slices and contents later. OTOH, we cannot remove |
I just need crun and uidmap for my use case, and it's working. I my last fixup I removed the debconf slice and dependency declaration to it. |
There was a problem hiding this comment.
Thank you for the changes. If the tests pass, it all LGTM. Another approval (@rebornplusplus ) and I'll merge it ;)
|
@rebornplusplus can you please approve again? I think you were re-requested by mistake |
Proposed changes
Forward porting
Testing
chisel cut \ --release ./ \ --root rootfs/ \ crun_bins uidmap_bins 2024/04/20 11:50:59 Processing ./ release... 2024/04/20 11:51:00 Selecting slices... 2024/04/20 11:51:00 Fetching ubuntu 24.04 noble suite details... 2024/04/20 11:51:01 Release date: Sat, 20 Apr 2024 10:00:49 UTC 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble main component... 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble universe component... 2024/04/20 11:51:01 Fetching ubuntu 24.04 noble-security suite details... 2024/04/20 11:51:01 Release date: Thu, 04 Jan 2024 18:43:12 UTC 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble-security main component... 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble-security universe component... 2024/04/20 11:51:01 Fetching ubuntu 24.04 noble-updates suite details... 2024/04/20 11:51:01 Release date: Sat, 20 Apr 2024 10:01:41 UTC 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble-updates main component... 2024/04/20 11:51:01 Fetching index for ubuntu 24.04 noble-updates universe component... 2024/04/20 11:51:01 Fetching pool/main/g/glibc/libc6_2.39-0ubuntu8_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libc/libcap2/libcap2_2.66-5ubuntu2_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libs/libseccomp/libseccomp2_2.5.5-1ubuntu3_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libg/libgpg-error/libgpg-error0_1.47-3build2_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libg/libgcrypt20/libgcrypt20_1.10.3-2build1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/l/lz4/liblz4-1_1.9.4-1build1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/x/xz-utils/liblzma5_5.6.1+really5.4.5-1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libz/libzstd/libzstd1_1.5.5+dfsg2-2build1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/s/systemd/libsystemd0_255.4-1ubuntu7_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/y/yajl/libyajl2_2.1.0-5build1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/universe/c/crun/crun_1.14.1-1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/a/audit/libaudit-common_3.1.2-2.1build1_all.deb... 2024/04/20 11:51:01 Fetching pool/main/libc/libcap-ng/libcap-ng0_0.8.4-2build2_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/a/audit/libaudit1_3.1.2-2.1build1_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/p/pcre2/libpcre2-8-0_10.42-4ubuntu2_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/libs/libselinux/libselinux1_3.5-2ubuntu2_amd64.deb... 2024/04/20 11:51:01 Fetching pool/main/s/shadow/uidmap_4.13+dfsg1-4ubuntu3_amd64.deb... 2024/04/20 11:51:01 Extracting files from package "libc6"... 2024/04/20 11:51:01 Extracting files from package "libcap2"... 2024/04/20 11:51:01 Extracting files from package "libseccomp2"... 2024/04/20 11:51:01 Extracting files from package "libgpg-error0"... 2024/04/20 11:51:01 Extracting files from package "libgcrypt20"... 2024/04/20 11:51:01 Extracting files from package "liblz4-1"... 2024/04/20 11:51:01 Extracting files from package "liblzma5"... 2024/04/20 11:51:01 Extracting files from package "libzstd1"... 2024/04/20 11:51:01 Extracting files from package "libsystemd0"... 2024/04/20 11:51:01 Extracting files from package "libyajl2"... 2024/04/20 11:51:01 Extracting files from package "crun"... 2024/04/20 11:51:01 Extracting files from package "libaudit-common"... 2024/04/20 11:51:01 Extracting files from package "libcap-ng0"... 2024/04/20 11:51:01 Extracting files from package "libaudit1"... 2024/04/20 11:51:01 Extracting files from package "libpcre2-8-0"... 2024/04/20 11:51:01 Extracting files from package "libselinux1"... 2024/04/20 11:51:01 Extracting files from package "uidmap"...Checklist
Additional Context