-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spread: add spread and CI testing for core20 version of core-initrd #72
Conversation
sudo apt-get remove --purge shellcheck | ||
sudo snap install shellcheck | ||
|
||
find tools -type f -exec sh -c "head -n 1 {} | egrep -a 'bin/bash|bin/sh' >/dev/null" \; -print -exec shellcheck {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not fail on file names with spaces, that should work better:
find tools -type f -exec sh -c 'head -n 1 "${1}" | egrep -a "bin/bash|bin/sh" >/dev/null' '--' {} \; -print -exec shellcheck {} \;
@@ -0,0 +1,674 @@ | |||
GNU GENERAL PUBLIC LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this commit imports some shared code from somewhere else. What is the procedure to keep track of updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…/external/snapd-testing-tools'
use systemd-run to start the inner qemu instance, remove the wait_for_service, add few missing comments
This is an identical PR to the one done in core20 PR that adds the 'spread lxd-nested' testing backend, and updates documentation on how to test with qemu backend as well.
This also adds the snapd-testing-tools repository (so sorry for the size), and switches our CI to self-hosted runners that should enable PRs to run tests. I have also enabled testing for the core20 branch.
I will create a PR for the main branch as well that is modified to work with jammy.