Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread: add spread and CI testing for core20 version of core-initrd #72

Merged
merged 14 commits into from
Jan 28, 2022

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Jan 25, 2022

This is an identical PR to the one done in core20 PR that adds the 'spread lxd-nested' testing backend, and updates documentation on how to test with qemu backend as well.

This also adds the snapd-testing-tools repository (so sorry for the size), and switches our CI to self-hosted runners that should enable PRs to run tests. I have also enabled testing for the core20 branch.

I will create a PR for the main branch as well that is modified to work with jammy.

@Meulengracht Meulengracht marked this pull request as ready for review January 25, 2022 11:28
@Meulengracht Meulengracht linked an issue Jan 25, 2022 that may be closed by this pull request
sudo apt-get remove --purge shellcheck
sudo snap install shellcheck

find tools -type f -exec sh -c "head -n 1 {} | egrep -a 'bin/bash|bin/sh' >/dev/null" \; -print -exec shellcheck {} \;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not fail on file names with spaces, that should work better:

find tools -type f -exec sh -c 'head -n 1 "${1}" | egrep -a "bin/bash|bin/sh" >/dev/null' '--' {} \; -print -exec shellcheck {} \;

@@ -0,0 +1,674 @@
GNU GENERAL PUBLIC LICENSE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this commit imports some shared code from somewhere else. What is the procedure to keep track of updates?

Copy link
Collaborator

@valentindavid valentindavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that 527b358 adds files later removed by 54d9d03. Could you remove those commits from the history. Also 82d1fad is empty, please remove it.

Copy link
Collaborator

@valentindavid valentindavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did 132e13a remove tests/lib/nested.sh and b8b0c92 re-added modified? It makes it difficult to review.

use systemd-run to start the inner qemu instance, remove the wait_for_service, add few missing comments
@Meulengracht Meulengracht merged commit 6f7d7a4 into canonical:core20 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants