fix(test): fix application tests

canonical · Feb 21, 2025 · 40d2762 · 40d2762
1 parent 98832c8
commit 40d2762
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/craft_application/application.py b/craft_application/application.py
@@ -590,7 +590,7 @@ def _run_inner(self) -> int:
             build_for = build_for.split(",", maxsplit=1)[0]
         if command.needs_project(dispatcher.parsed_args()):
             project_service = self.services.get("project")
-            # This is only needed for testing.
+            # This branch always runs, except during testing.
             if not project_service.is_rendered:
                 project_service.render_once()
 

diff --git a/tests/unit/test_application.py b/tests/unit/test_application.py
@@ -472,13 +472,13 @@ def test_gets_project(monkeypatch, fake_project_file, app_metadata, fake_service
 
 
 def test_fails_without_project(
-    monkeypatch, capsys, tmp_path, app_metadata, fake_services, app
+    monkeypatch, capsys, tmp_path, app_metadata, fake_services, app, debug_mode
 ):
-    monkeypatch.setattr(sys, "argv", ["testcraft", "prime"])
-
-    app.project_dir = tmp_path
+    # Set up a real project service - the fake one for testing gets a fake project!
+    del app.services._services["project"]
+    app.services.register("project", services.ProjectService)
 
-    fake_services.project = None
+    monkeypatch.setattr(sys, "argv", ["testcraft", "prime"])
 
     assert app.run() == 66