-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to starflow and Makefile #143
Conversation
5cbd270
to
f66691c
Compare
f17298e
to
bb23dca
Compare
This was causing issues with the slow tests
HACKING.rst comes almost directly from starbase.
bb23dca
to
04c44a5
Compare
5dbbf1a
to
b8849da
Compare
b8849da
to
6ba5f2c
Compare
Co-authored-by: Upils <[email protected]>
When I run
Didn't we configure ruff to ignore that autogenerated file at some point? |
@tigarmo we did, but it never got brought into craft-archives it seems. I've added it now. |
@lengau thanks. I think the ruff update broke linting
do you know how we can avoid this modification? Should we use |
This includes freezing UV by default: canonical/starbase#322
@tigarmo good catch! That's an oversight I've fixed upstream in canonical/starbase#322 and brought here. I also auto-formatted with the latest changes (which includes switching from yamllint to prettier). |
@lengau thanks for this! Once the checks finish I'll update the required ones & merge |
make lint && make test
?This will be easiest to review on a per-commit basis.
Fixes #146
CRAFT-3835