Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moved react packages to their domain, added the launchpad tier #109

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

advl
Copy link
Contributor

@advl advl commented Jan 14, 2025

Done

  • Renamed ds-react-core to react-ds-core

  • Moved packages/react-ds-core to packages/react/ds-core

  • Copied paclages/react/ds-core to packages/react/ds-app-launchpad

  • (Other) removed generator-canonical-ds from apps, which was an older, archived version

  • Added new workspace entries in main package.json

(Excluded - Renamed boilerplate-react-vite to boilerplate-vite and moved to apps/react/boilerplate-vite)

QA

  • bun i should work fine
  • cd packages/react/ds-core and bun run storybook, bun run build should work fine
  • cd packages/react/ds-app-launchpad and bun run storybook, bun run build should work fine

PR readiness check

  • PR should have one of the following labels:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • All packages define the required scripts in package.json:
    • All packages: check, check:fix, and test.
    • Packages with a build step: build.

@advl advl changed the title Ft tiers domains ft: moved react packages to their domain, added the launchpad tier Jan 14, 2025
@jmuzina jmuzina changed the title ft: moved react packages to their domain, added the launchpad tier feat: moved react packages to their domain, added the launchpad tier Jan 14, 2025
@jmuzina jmuzina merged commit ee65323 into main Jan 14, 2025
2 checks passed
@jmuzina jmuzina deleted the ft-tiers-domains branch January 14, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants