-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bun / TSC build structure & comparison #17
Conversation
CI fails due to Typescript & Biome disagreeing on whether React imports should use I am making a change to the biome configuration's We should use |
31fa805
to
ac62f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be merged
Two minor things (for a future PR ?)
- document the local override of
"allowSyntheticDefaultImports": true
in ds/tsconfig.json - let's try to use the modern
react-jsx
and make it work with biome ?
@advl I was able to remove this override without causing any errors - I think that was a holdover from our debugging stages.
I was able to safely switch this over to modern Let me know if there's something I've missed that needs to be investigated as part of a separate PR. |
Note: includes changes from #16 , review and merge that PR first.
Builds the
ds
package with bothtsc
&bun build
, roughly following the structure shown here.This functions as an exploration of the benefits and drawbacks of
tsc
andbun build
.A comparison of their outcomes and our findings are included in
README
files introduced by this PR.