Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vitest for React core UI #72

Merged
merged 7 commits into from
Dec 20, 2024
Merged

feat: Add vitest for React core UI #72

merged 7 commits into from
Dec 20, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Dec 11, 2024 •
edited
Loading

Done

Adds design system component tests with vitest.

See testing framework decision.

QA

  • See that the CI passes and includes a Vitest test for the react core UI.

PR readiness check

  • PR should have one of the following labels:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • All packages define the required scripts in package.json:
    • All packages: check and check:fix.
    • Packages with a build step: build.

@jmuzina jmuzina changed the title Add vitest for react core feat: Add vitest for React core UI Dec 11, 2024
@jmuzina jmuzina marked this pull request as ready for review December 13, 2024 17:13
@jmuzina jmuzina requested a review from advl December 13, 2024 17:13
@jmuzina jmuzina requested a review from bartaz December 13, 2024 20:24
advl
advl reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@advl advl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/pr.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
.github/workflows/tag.yml Outdated Show resolved Hide resolved
@jmuzina jmuzina requested a review from advl December 17, 2024 14:26
@advl
Copy link
Contributor

advl commented Dec 18, 2024

It looks good, however please add more documentation about the choice of vitest, it's relative independence from vite, and the general, choosen testing setup.

advl
advl requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@advl advl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@jmuzina jmuzina force-pushed the vitest branch 4 times, most recently from 1987f68 to 94e0793 Compare December 19, 2024 20:28
jmuzina
jmuzina commented Dec 19, 2024
View reviewed changes
Copy link
Member Author

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving explanatory comments for reviewers' benefit.

nx.json Show resolved Hide resolved
packages/ds-react-core/tsconfig.build.json Show resolved Hide resolved
packages/ds-react-core/tsconfig.build.json Show resolved Hide resolved
packages/ds-react-core/tsconfig.json Show resolved Hide resolved
packages/generator-ds/src/component/templates/Component.test.tsx.ejs Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@jmuzina jmuzina requested a review from advl December 19, 2024 20:38
advl
advl reviewed Dec 19, 2024
View reviewed changes
guides/TESTING.md Outdated Show resolved Hide resolved
advl
advl requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@advl advl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. thanks for the PR

@advl advl merged commit dfa9c4e into main Dec 20, 2024
2 checks passed
@jmuzina jmuzina deleted the vitest branch January 17, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advl advl advl approved these changes

@bartaz bartaz Awaiting requested review from bartaz

Assignees
No one assigned
Labels
Feature 🎁 Priority: Moderate Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmuzina @advl