Implement get_stale_profiles and delete_stale_profiles
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimwnasptd
requested changes
Jan 14, 2025
tests/integration/profiles_management/test_get_stale_profiles.py
Outdated
Show resolved
Hide resolved
tests/integration/profiles_management/test_get_stale_profiles.py
Outdated
Show resolved
Hide resolved
kimwnasptd
reviewed
Jan 14, 2025
tests/integration/profiles_management/test_get_stale_profiles.py
Outdated
Show resolved
Hide resolved
kimwnasptd
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
This PR is a substep of #8. It adds the following 2 functions:
get_stale_profiles, which returns a dictionary of the profiles that exist in the cluster but not in the PMRdelete_stale_profiles, which deletes all stale profiles from the clusterTests
2 integration tests have been added, under
tests/integration/profile_managementto tests that the 2 function work as expected.