Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site url #394

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Remove site url #394

wants to merge 33 commits into from

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented May 7, 2024

Applicable spec:
N/A

Overview

Remove the site_url configuration option and configure the external hostname through the nginx-route relation.

Rationale

N/A

Juju Events Changes

N/A

Module Changes

charm.py

Library Changes

NA

Checklist

@canonical canonical deleted a comment from github-actions bot May 7, 2024
@canonical canonical deleted a comment from github-actions bot May 10, 2024
@canonical canonical deleted a comment from github-actions bot May 10, 2024
@arturo-seijas arturo-seijas reopened this May 20, 2024
Copy link
Contributor

Lint checks failed for 58c3eed

```

--- /home/ubuntu/github-runner/_work/indico-operator/indico-operator/tests/integration/conftest.py 2024-05-22 17:53:57.113780+00:00
+++ /home/ubuntu/github-runner/_work/indico-operator/indico-operator/tests/integration/conftest.py 2024-05-22 17:55:02.045220+00:00
@@ -79,13 +79,17 @@
"postgresql-k8s", channel="14/edge", config=postgresql_config, trust=True
),
ops_test.model.deploy("redis-k8s", "redis-broker", channel="latest/edge"),
ops_test.model.deploy("redis-k8s", "redis-cache", channel="latest/edge"),
ops_test.model.deploy(

  •        "nginx-ingress-integrator", channel="latest/edge", series="focal", config={
    
  •        "nginx-ingress-integrator",
    
  •        channel="latest/edge",
    
  •        series="focal",
    
  •        config={
               "service-hostname": hostname,
    
  •        }, trust=True
    
  •        },
    
  •        trust=True,
       ),
    
    )
    await ops_test.model.wait_for_idle(
    apps=["postgresql-k8s"], status="active", raise_on_error=False
    )

Copy link
Contributor

Test coverage for 58c3eed

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 304      9     76      7    96%   575, 612-613, 701->717, 703->712, 712->717, 725-726, 765, 798->exit, 836-842
src/database_observer.py      33      0      4      0   100%
src/s3_observer.py            18      0      0      0   100%
src/saml_observer.py          15      0      0      0   100%
src/smtp_observer.py          16      0      0      0   100%
src/state.py                  74      0     10      0   100%
----------------------------------------------------------------------
TOTAL                        460      9     90      7    97%

Static code analysis report

Run started:2024-05-22 17:55:17.479716

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2841
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant