Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative CNI How-to #900

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Alternative CNI How-to #900

merged 10 commits into from
Jan 8, 2025

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Dec 12, 2024 •
edited by louiseschmidtgen
Loading

Alternative CNI How-to

This PR adds a how-to page for installing an alternative CNI by the example of Calico.

@eaudetcobello eaudetcobello requested a review from a team as a code owner December 12, 2024 20:32
bschimke95
bschimke95 reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit
Leaving the approval to @nhennigan

docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
nhennigan
nhennigan reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 😄

Please add to the index file so it appears in the navigation and address the small changes and I think it will be good to go

docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
louiseschmidtgen
louiseschmidtgen reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @eaudetcobello!
Left you a couple of suggestions.

docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
@louiseschmidtgen louiseschmidtgen changed the title alternative cni docs Alternative CNI how-to Dec 17, 2024
louiseschmidtgen
louiseschmidtgen reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things :)

docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
@louiseschmidtgen louiseschmidtgen changed the title Alternative CNI how-to Alternative CNI How-to Dec 17, 2024
louiseschmidtgen
louiseschmidtgen reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Etienne, some last little comments then we can send it off.

docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
docs/src/snap/howto/networking/alternative-cni.md Show resolved Hide resolved
louiseschmidtgen
louiseschmidtgen approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I found one more little capitalization error, please address it and then merge the PR :)

docs/src/snap/howto/networking/alternative-cni.md Outdated Show resolved Hide resolved
louiseschmidtgen
louiseschmidtgen reviewed Jan 8, 2025
View reviewed changes
docs/src/snap/howto/networking/alternative-cni.md
cat <<EOF > bootstrap-config.yaml
cluster-config:
network:
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing the closing EOF here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@eaudetcobello eaudetcobello merged commit 57ca4dd into main Jan 8, 2025
6 checks passed
@eaudetcobello eaudetcobello deleted the KU-226/alt-cni-docs branch January 8, 2025 19:09
HomayoonAlimohammadi pushed a commit that referenced this pull request Feb 4, 2025
@eaudetcobello @HomayoonAlimohammadi
Alternative CNI How-to (#900)
37bf21e
HomayoonAlimohammadi pushed a commit that referenced this pull request Feb 12, 2025
@eaudetcobello @HomayoonAlimohammadi
Alternative CNI How-to (#900)
6c3ae3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen louiseschmidtgen approved these changes

@bschimke95 bschimke95 bschimke95 left review comments

@nhennigan nhennigan nhennigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eaudetcobello @nhennigan @louiseschmidtgen @bschimke95