Skip to content

Commit

Permalink
nit: address comments for consistency with data repos
Browse files Browse the repository at this point in the history
  • Loading branch information
NohaIhab committed Jan 21, 2025
1 parent 1a65f8d commit 47b983c
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/on_pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Generate the Charm Matrix content
runs-on: ubuntu-latest
outputs:
charm_paths: ${{ steps.get-charm-paths.outputs.charm-paths }}
charm-paths: ${{ steps.get-charm-paths.outputs.charm-paths }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -22,15 +22,14 @@ jobs:
uses: canonical/kubeflow-ci/actions/get-charm-paths@main

build:
name: Build charm | ${{ matrix.charm }}
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
needs: get-charm-paths
strategy:
matrix:
charm: ${{ fromJSON(needs.get-charm-paths.outputs.charm_paths) }}
charm: ${{ fromJSON(needs.get-charm-paths.outputs.charm-paths) }}
name: Build charm | ${{ matrix.charm }}
needs:
- get-charm-paths
with:
# Update to 3.x/stable once the latest/candidate is released to that track
charmcraft-snap-channel: latest/candidate
charmcraft-snap-channel: latest/candidate # TODO: remove after charmcraft 3.3 stable release
path-to-charm-directory: ${{ matrix.charm }}

tests:
Expand Down

0 comments on commit 47b983c

Please sign in to comment.