Skip to content

Commit

Permalink
fix: use full svc name and namespace for METADATA_GRPC_SERVICE_HOST e…
Browse files Browse the repository at this point in the history
…nv var (#361)

The METADATA_GRPC_SERVICE_HOST env var has to include the name
and namespace of the metadata grpc server, otherwise pipeline runs
end in errors when trying to write in the metadata SQLite DB.

This commit reverts a change introduced by canonical/kfp-operators#3312.
  • Loading branch information
DnPlas authored Oct 27, 2023
1 parent 1c49759 commit e15dd68
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charms/kfp-profile-controller/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# This service name must be the Service from the mlmd-operator
# FIXME: leaving it hardcoded now, but we should share this
# host and port through relation data
METADATA_GRPC_SERVICE_HOST = "metadata-grpc-service"
METADATA_GRPC_SERVICE_HOST = "metadata-grpc-service.kubeflow"
METADATA_GRPC_SERVICE_PORT = "8080"
NAMESPACE_LABEL = "pipelines.kubeflow.org/enabled"
SYNC_CODE_FILE = Path("files/upstream/sync.py")
Expand Down

0 comments on commit e15dd68

Please sign in to comment.