reformat kfp-profile-controller's sync.py to match upstream #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implement a sync.py file from upstream which we lightly modify. This commit reformats that sync.py to be as similar as possible to upstream's sync.py for easier comparison and maintenance. #331 previously reformatted sync.py to meet our style guide, but that made it harder to track and changes upstream and import them into our version This should have no functional change on the charm, it only changes things to make maintenance easier.
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
DnPlas
approved these changes
Nov 8, 2023
DnPlas
pushed a commit
that referenced
this pull request
Nov 20, 2023
We implement a sync.py file from upstream which we lightly modify. This commit reformats that sync.py to be as similar as possible to upstream's sync.py for easier comparison and maintenance. #331 previously reformatted sync.py to meet our style guide, but that made it harder to track and changes upstream and import them into our version This should have no functional change on the charm, it only changes things to make maintenance easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kfp-profile-controller implements a sync.py file from upstream which we lightly modify. This commit reformats that sync.py to be as similar as possible to upstream's sync.py for easier comparison and maintenance. #331 previously reformatted sync.py to meet our style guide, but that made it harder to track and changes upstream and import them into our version
This should have no functional change on the charm, it only changes things to make maintenance easier.