ci, tests: pass charm artefacts to deploy and test charms #640
Conversation
DnPlas
force-pushed
the
KF-6696-use-charm-artefacts-individual
branch
2 times, most recently
from
f8108f1 to
be89868
Compare
DnPlas
changed the title
DnPlas
force-pushed
the
KF-6696-use-charm-artefacts-individual
branch
from
09f67cb to
7e97d95
Compare
DnPlas
force-pushed
the
KF-6696-use-charm-artefacts-individual
branch
from
7e97d95 to
a425c46
Compare
This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: #639
DnPlas
force-pushed
the
KF-6696-use-charm-artefacts-individual
branch
from
a425c46 to
57f219b
Compare
…artefacts-individual
.github/workflows/integrate.yaml
Outdated
| - name: Integration tests | ||
| if: steps.download-charms.outcome == 'success' |
There was a problem hiding this comment.
Why do we need this? Won't it fail by itself?
There was a problem hiding this comment.
Maybe left it by mistake, I can remove it.
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright 2024 Canonical Ltd. | |||
There was a problem hiding this comment.
nit: 2025? 😄 FYI I saw a discussion that we don't have to update this every year, but rather use the year when the code was created so I guess it would be 2025 here.
| def pytest_addoption(parser: Parser): | ||
| parser.addoption( | ||
| "--charm-path", | ||
| help="Path to charm file when downloaded as artefact as a result of build_charm.yaml", |
There was a problem hiding this comment.
I think the description should not be tied to the CI use ie build_charm.yaml. It is a valid use case in any environment really.
There was a problem hiding this comment.
If this makes sense to you, it would also make sense to modify the comment below
Keep the option to run the integration tests locally
by building the charm and then deploying
There was a problem hiding this comment.
I have rephrased it to make it more generic.
There was a problem hiding this comment.
Maybe we should avoid formatting this file? This way, it 'll be easier to check for changes during manifests update. Although we could just check the changes in the upstream files, but still, it's kind of an irrelevant change here.
There was a problem hiding this comment.
Agreed, will remove it. Was a quick formatting that got incorrectly added.
There was a problem hiding this comment.
These changes look also unrelated
* ci, tests: pass charm artefacts to deploy and test charms This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: #639 Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax skip: remove duplicated download-charms remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output skip: rename job in needs pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658)
Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658) Co-authored-by: Daniela Plascencia <[email protected]>
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).
Fixes: #639
Review and merge after #642, and canonical/charmed-kubeflow-workflows#90