-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove wrapper around get charm paths and build with cache workflows #651
ci: remove wrapper around get charm paths and build with cache workflows #651
Conversation
This commit removes the extra abstraction of the get-charm-paths action and build_charm.yaml reusable workflow to avoid potential incompatibilities and sync issues with the data platforms workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @DnPlas, a couple comments on changes for the workflow and charmcraft versions. I suggest @carlcsaposs-canonical to also give it a review to ensure we are reusing their workflow as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small notes.
suggestion: We could update the actions/checkout
step to actions/checkout@v4
since we're updating the workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM!
1a58b13
into
KF-6684-refactor-ci-with-build
This commit removes the extra abstraction of the get-charm-paths action and build_charm.yaml reusable workflow to avoid potential incompatibilities and sync issues with the data platforms workflows.
Notes to reviewer:
build_charm
workflow from data platform inOn Push
workflow #650