Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove wrapper around get charm paths and build with cache workflows #651

Merged

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jan 16, 2025

This commit removes the extra abstraction of the get-charm-paths action and build_charm.yaml reusable workflow to avoid potential incompatibilities and sync issues with the data platforms workflows.

Notes to reviewer:

This commit removes the extra abstraction of the get-charm-paths action and
build_charm.yaml reusable workflow to avoid potential incompatibilities
and sync issues with the data platforms workflows.
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DnPlas, a couple comments on changes for the workflow and charmcraft versions. I suggest @carlcsaposs-canonical to also give it a review to ensure we are reusing their workflow as expected.

.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/integrate.yaml Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/integrate.yaml Show resolved Hide resolved
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small notes.

suggestion: We could update the actions/checkout step to actions/checkout@v4 since we're updating the workflows.

Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM!

@NohaIhab NohaIhab merged commit 1a58b13 into KF-6684-refactor-ci-with-build Jan 21, 2025
89 of 92 checks passed
@NohaIhab NohaIhab deleted the KF-6684-remove-wrapper-from-integrate branch January 21, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants