-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certs generated by LXD-UI are not following best practices #1084
Comments
Thanks for the report. The subject needs cleanup for sure! I remember going back to some legacy settings for creating certs that are compatible with Mac OS at some point in the past. I will adjust to your suggested settings and test on different browsers and operating systems. Ideally we reach settings that align with best practices and work everywhere. |
Oh, that's surprising considering that Apple is pushing hard for the certificate/PKI ecosystem to improve (short cert lifetime being their latest focus).
Thank you!
Hopefully that will be without SHA1 even for macOS. |
Briefly looked into this. We can generate an ECC CryptoKeyPair with the web crypto API. Problem is, the crypto API does not give us a pfx file. We currently use forge for converting the keys to pfx, but it only supports RSA. A PR to add support for ECC is open for a long time. As I can see they are mixing the generation and not using the crypto API to generate the keys yet in the PR. Maybe we should chip in and help out over there. |
If browser libraries are the limiting factor, what about having the cli generate the certificates instead? Step 2 in the Generate Certificate proces is to go back to the cli and add it to the trust store. I think it would be a smoother experience to have both step 1 and step 2 on the cli so that you can combine these steps. I personally generate certificates myself with If you're a single user then |
## Done - Remove arbitrary fields from the generated cert relates to #1084 ## QA 1. Run the LXD-UI: - On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access. - With a local copy of this branch, [build and run as described in the docs](../CONTRIBUTING.md#setting-up-for-development). 2. Perform the following QA steps: - generate a cert, ensure it is generated without country and state and works in the browser
I asked the LXD-UI (from LXD
latest/edge
) to generate a certificate and got one using RSA-2048 with SHA1 signature. Both are sub-optimal in terms of security. ECDSA P-384 with SHA384 would be in line with what the CLI client generates. Also, theC
andST
fields in theIssuer
andSubject
fields should probably be dropped instead of getting invalid values.I get a similarly looking certificate with Firefox 134.0.2 and Chromium 132.0.6834.83.
The text was updated successfully, but these errors were encountered: