Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arbitrary fields from the generated cert #1106

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 12, 2025

Done

  • Remove arbitrary fields from the generated cert

relates to #1084

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • generate a cert, ensure it is generated without country and state and works in the browser

@webteam-app
Copy link

Copy link
Contributor

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Can confirm those fields are gone and it still works for lxd auth

Screenshot from 2025-02-12 18-59-29

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sound enough. What is the reason for these removals? I also assume that this has been tested.

@edlerd edlerd force-pushed the cleanup-cert-fields branch from 34d9cdf to ef7144d Compare February 12, 2025 17:46
@edlerd edlerd merged commit 2f89307 into canonical:main Feb 12, 2025
11 checks passed
@edlerd
Copy link
Collaborator Author

edlerd commented Feb 12, 2025

Thanks for testing and validation! The reasoning is mentioned in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants