adr: dashboard collision #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucabello just for reference, could you mention the length and charset limits for title, uid? |
Signed-off-by: Leon <[email protected]>
Signed-off-by: Leon <[email protected]>
mmkay
reviewed
Oct 11, 2024
|
|
||
| ### (6/P) Let charm authors or admins specify the folder name under which grafana should place its dashboards | ||
|
|
||
| This would solve (2) if charm authors configure their charms correctly. The default behavior would be either the "General" folder (as it is right now) or a folder named after the charm name. |
There was a problem hiding this comment.
I think it might be nice from the "not surprising users" perspective to keep the "General" folder as the default.
I really like the ability to specify a directory though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update our dashboard best practices with the outcome of this ADR.
Related: