Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use [email protected] in TF modules #427

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Dec 18, 2024

Description

By default, Juju fetches charms with base matching the host OS. It means that when running Jammy, Juju won’t use latest charms, because we’ve changed the base to Noble.

Adding an optional (as per CC006) config param base will allow using Noble (base should be set to [email protected]) regardless of the host OS.

Enforcing Noble on a Juju model configuration level is not an option, because it breaks COS integration (COS charms are not available in [email protected]).

ATTENTION

As a workaround to this issue juju/python-libjuju#1240 we use, series instead of base in the integration tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso patriciareinoso requested a review from a team as a code owner December 18, 2024 09:36
@patriciareinoso patriciareinoso requested a review from a team December 18, 2024 15:15
@patriciareinoso patriciareinoso force-pushed the TELCO-1545-1.5-use-noble branch from 725f67d to 2dc717f Compare December 18, 2024 16:22
@patriciareinoso patriciareinoso merged commit 612cd42 into v1.5 Dec 19, 2024
10 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1545-1.5-use-noble branch December 19, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants