Fix None iteration

canonical · Oct 16, 2024 · 3467c97 · 3467c97
1 parent de2a11c
commit 3467c97
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/snapcraft/extensions/qt_framework.py b/snapcraft/extensions/qt_framework.py
@@ -21,7 +21,7 @@
 
 from overrides import overrides
 
-from .extension import Extension, get_extensions_data_dir, prepend_to_env
+from .extension import Extension, prepend_to_env
 
 _SDK_SNAP = {"core22": "qt-framework-sdk"}
 
@@ -219,7 +219,7 @@ def get_parts_snippet(self) -> Dict[str, Any]:
         sdk_channel = self.qt_snaps.sdk["channel"]
 
         if self.qt_snaps.builtin:
-            return None
+            return {}
 
         return {
             f"{self.name}/sdk": {

diff --git a/tests/unit/extensions/test_qt_framework.py b/tests/unit/extensions/test_qt_framework.py
@@ -17,7 +17,6 @@
 import pytest
 
 from snapcraft.extensions import qt_framework
-from snapcraft.extensions.extension import get_extensions_data_dir
 from snapcraft.extensions.qt_framework import _CONTENT_SNAP
 
 ############
@@ -261,11 +260,11 @@ def test_get_parts_snippet(qt_framework_extension, name):
 
 @pytest.mark.parametrize(fixture_variables, builtin_stable_values)
 def test_get_parts_snippet_with_external_sdk(qt_framework_extension, name):
-    assert qt_framework_extension.get_parts_snippet() == None
+    assert qt_framework_extension.get_parts_snippet() == {}
 
 
 @pytest.mark.parametrize(fixture_variables, builtin_edge_values)
 def test_get_parts_snippet_with_external_sdk_different_channel(
     qt_framework_extension, name
 ):
-    assert qt_framework_extension.get_parts_snippet() == None
+    assert qt_framework_extension.get_parts_snippet() == {}