fix(expand-extensions): use the Application's project #5106
Conversation
Fixes LP bug https://bugs.launchpad.net/snapcraft/+bug/2083964 Instead of parsing the project again itself, expand-extensions now uses the project provided by the application. The output is changed slightly, but I believe it reflects a more accurate expansion.
lengau
force-pushed
the
work/lp-2083964
branch
from
b165507 to
c64cea8
Compare
This failure is a consequence of using pydantic validators to modify the data here. There's probably not a way around this error besides removing that validator. |
|
@mr-cal as a note I had to change some other tests for that. |
There was a problem hiding this comment.
This PR is exposing chain of errors! I suspect we have been using the wrong expand-extensions for core20 snaps for a long time, but never noticed.
We have this check to raise a ClassicFallback, but we are missing the next check to raise a LegacyFallback.
list-plugins is similar, I think you can steal these lines.
| @pydantic.field_validator("build_base") | ||
| @classmethod | ||
| def _validate_build_base( | ||
| cls, value: str | None, info: pydantic.ValidationInfo | ||
| ) -> str | None: | ||
| """Build-base defaults to the base value if not specified.""" | ||
| return value or info.data.get("base") | ||
|
|
There was a problem hiding this comment.
Heck yeah. This should be safe to remove and should be removed, so thanks for yanking off the bandage!
Fixes LP bug https://bugs.launchpad.net/snapcraft/+bug/2083964
Instead of parsing the project again itself, expand-extensions now uses the project provided by the application. The output is changed slightly, but I believe it reflects a more accurate expansion.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)