Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add patchelf to dev dependencies for testing #5135

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix(test): add patchelf to dev dependencies for testing #5135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(test): add patchelf to dev dependencies for testing
@bepri
bepri committed Oct 28, 2024
commit 3248e55002c9c548db89a4062d7e2e64026495ce
1 change: 1 addition & 0 deletions requirements-devel.txt
View file
Original file line number Diff line number Diff line change
@@ -84,6 +84,7 @@ oauthlib==3.2.2
overrides==7.7.0
packaging==24.1
PasteDeploy==3.1.0
patchelf==0.17.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know requirements*.txt files are auto-generated and we keep dependencies in pyproject.toml or setup.py.
If I'm not mistaken this dependency should be added here, and then you should run tools/freeze-requirements.sh script.
https://github.com/canonical/snapcraft/blob/main/setup.py#L61

pathspec==0.12.1
pbr==6.0.0
pexpect==4.9.0
1 change: 0 additions & 1 deletion tools/environment-setup-local.sh
View file
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@ sudo apt install --yes \
libxslt1-dev \
libyaml-dev \
make \
patchelf \
python3-dev \
python3-pip \
python3-venv \