Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upstream the good parts when rebasing application #265

Merged
merged 25 commits into from
Oct 11, 2024
Merged

feat: upstream the good parts when rebasing application #265

merged 25 commits into from
Oct 11, 2024

Conversation

mattculler
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@mattculler mattculler self-assigned this Oct 1, 2024
lengau
lengau reviewed Oct 1, 2024
View reviewed changes
lengau
lengau reviewed Oct 1, 2024
View reviewed changes
lengau
lengau reviewed Oct 1, 2024
View reviewed changes
@mattculler mattculler changed the title Upstream the good parts when rebasing application feat: upstream the good parts when rebasing application Oct 1, 2024
mattculler and others added 7 commits October 1, 2024 23:01
@mattculler
feat: more upstreaming
c6ff7bf 
- Compared .gitignores and added things from my application.
- Removed redundant black things in hook file.
- Ruff format should be after check, as sometimes check's output needs to be
formatted, but format's output shouldn't need to be checked.
- Updated refactor instructions.
- Updated ruff excludes.
- Helped pyright's type checking.
@mattculler @lengau
Apply suggestions from code review
661bff4 
Co-authored-by: Alex Lowe <[email protected]>
@mattculler
fix: Alex's PR review
0ba5218
@mattculler
feat(Makefile): upstream coverage target
7689a04
@mattculler
feat(docs): update readme with integration test info
af8411d
@mattculler
feat: upstream minor tests workflow things
f6e813f
@mattculler
fix: uv snap has added aliases and doesn't need beta
97f384f
lengau
lengau requested changes Oct 10, 2024
View reviewed changes
@mattculler mattculler requested a review from lengau October 10, 2024 18:12
@mattculler mattculler marked this pull request as ready for review October 10, 2024 18:13
@mattculler mattculler requested a review from dariuszd21 October 10, 2024 18:13
lengau
lengau reviewed Oct 11, 2024
View reviewed changes
@mattculler mattculler requested a review from lengau October 11, 2024 14:00
dariuszd21
dariuszd21 reviewed Oct 11, 2024
View reviewed changes
lengau
lengau reviewed Oct 11, 2024
View reviewed changes
lengau
lengau reviewed Oct 11, 2024
View reviewed changes
lengau
lengau approved these changes Oct 11, 2024
View reviewed changes
dariuszd21
dariuszd21 approved these changes Oct 11, 2024
View reviewed changes
@mattculler mattculler merged commit 44ce081 into main Oct 11, 2024
6 checks passed
@mattculler mattculler deleted the work/upstream-rebase-changes branch October 11, 2024 20:07
@mattculler mattculler mentioned this pull request Oct 11, 2024
Merged
3 tasks
mattculler added a commit that referenced this pull request Oct 11, 2024
@mattculler @lengau
fix: starbase breakage from #265 (#270)
9027b2c 
* fix: broken shell escaping

* fix: improper shell escaping and missed alias

* Update Makefile

Co-authored-by: Alex Lowe <[email protected]>

---------

Co-authored-by: Alex Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees

@mattculler mattculler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattculler @lengau @dariuszd21