When changing format of a new partition, don't require wipe #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Gayot <[email protected]>
ogayot
commented
Jan 27, 2025
| if data.partition.format is not None: | ||
| if data.partition.format != partition.original_fstype(): | ||
| if data.partition.wipe is None: | ||
| raise ValueError("changing partition format requires a wipe value") | ||
| if data.partition.wipe is None and partition.preserve: |
There was a problem hiding this comment.
Should we check the value of preserve at the FS level (which may or may not exist) ? This is what we do to label "to be reformatted as ...." and "to be formatted as ....".
subiquity/subiquity/common/filesystem/labels.py
Lines 228 to 235 in ad2dd0a
There was a problem hiding this comment.
@dbungert do you know? i.e., the difference between partition.preserve and partition.fs.preserve?
There was a problem hiding this comment.
I will defer to the curtin documentation on this one. https://curtin.readthedocs.io/en/latest/topics/storage.html
From a label standpoint this is a very subtle difference.
When dealing with a new partition, changing the format from e.g. ext4 to unformatted should not require a wipe value. There is nothing yet to wipe. OTOH it is still necessary for existing partitions. Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
wipe-change-format
branch
from
646207f to
60693ec
Compare
ogayot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP:#2097621