Pek614 adding attestation type tests #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hector-cao
approved these changes
Sep 20, 2024
|
|
||
| ssh = Qemu.QemuSSH(qm) | ||
|
|
||
| deploy_and_setup(ssh) |
There was a problem hiding this comment.
Very minor but I think for this test, we do not need deploy_and_setup() action
|
|
||
| def test_guest_measurement_trust_authority_success(): |
There was a problem hiding this comment.
i m wondering if we have to put these tests in a separate file, this file is initially reserved for tests of measurement values. i would suggest the new file name test_guest_attestation_ita or test_guest_attestation_quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://warthogs.atlassian.net/browse/PEK-614
Adding trustauthority-cli quote test.