Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_guest_cpu_off: fixes failure #230

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

hector-cao
Copy link
Collaborator

  • if we pin the process to a offline cpu core, the test will fail we need to bring the core online fist
  • add a cpu manager as context manager to easily restore the core state at the end of the test
  • move some utility code to util.py
  • make cpu random select more robust since on some systems core0 might not support the on/off feature (IRQ is wired on it)

- if we pin the process to a offline cpu core, the test will fail
  we need to bring the core online fist
- add a cpu manager as context manager to easily restore the core
  state at the end of the test
- move some utility code to util.py
- make cpu random select more robust since on some systems core0
  might not support the on/off feature (IRQ is wired on it)
Copy link
Contributor

@spmcmillan spmcmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

@hector-cao hector-cao merged commit 2433a4c into noble-24.04 Sep 23, 2024
1 check passed
@hector-cao hector-cao deleted the noble-24.04-fix-failing-test branch October 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants