Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandate host and port in database information #174

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Conversation

weiiwang01
Copy link
Collaborator

Overview

User feedback indicates that the WordPress charm might initiate the reconciliation process without a database endpoint provided in the database relation, leading to errors during database connectivity verification. Although we haven't been able to replicate this issue, updating the charm to prevent it from proceeding to reconciliation in the absence of a database endpoint in the database relation, as a precautionary measure.

Checklist

@weiiwang01 weiiwang01 added the bug Something isn't working label Nov 27, 2023
@weiiwang01 weiiwang01 requested a review from a team as a code owner November 27, 2023 05:11
yanksyoon
yanksyoon previously approved these changes Nov 27, 2023
jdkandersson
jdkandersson previously approved these changes Nov 27, 2023
amandahla
amandahla previously approved these changes Nov 28, 2023
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jdkandersson
jdkandersson previously approved these changes Nov 29, 2023
amandahla
amandahla previously approved these changes Nov 30, 2023
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Test coverage for 2344ab9

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          549     37    182     33    90%   191-194, 358-359, 418->422, 571, 602, 608, 625-629, 659, 694-695, 749, 758, 860->865, 864, 866, 871-872, 932, 950, 957, 1047, 1056, 1068, 1089, 1098, 1117, 1121, 1150, 1203, 1335, 1357, 1364->1366, 1409->exit, 1421, 1437, 1474, 1483-1484
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/state.py           34      0      4      0   100%
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 631     38    188     34    91%

Static code analysis report

Run started:2023-12-01 11:08:22.255458

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4473
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiiwang01 weiiwang01 merged commit a1ed8da into main Dec 5, 2023
35 checks passed
@weiiwang01 weiiwang01 deleted the fix-database-info branch December 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants