Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change health check period based on timeout #239

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

weiiwang01
Copy link
Collaborator

Overview

Change the health check period to be twice the health check timeout value. This is required because Pebble versions below 1.7 need the health check timeout value to be less than the health check period value. And newer Pebble versions will clamp the timeout value to be less than or equal to the health check period.

Checklist

@weiiwang01 weiiwang01 added the trivial This is a trivial PR label Sep 16, 2024
@weiiwang01 weiiwang01 requested a review from a team as a code owner September 16, 2024 05:38
Copy link

@hloeung hloeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

Test coverage for b902dcd

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          557     35    190     34    91%   162, 204-207, 299->302, 414, 473->477, 626, 657, 663, 680-684, 714, 749-750, 810, 819, 923->936, 935, 937, 942-943, 1003, 1023, 1030, 1120, 1129, 1141, 1162, 1171, 1190, 1194, 1223, 1264, 1396, 1418, 1425->1427, 1470->exit, 1482, 1492, 1530
src/cos.py             20      0      0      0   100%
src/exceptions.py      16      1      2      1    89%   41
src/state.py           33      0      4      0   100%
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 641     36    196     35    92%

Static code analysis report

Run started:2024-09-18 17:18:04.662339

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4644
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit a5d7e24 into main Sep 19, 2024
31 checks passed
@weiiwang01 weiiwang01 deleted the health-check-period branch September 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants