Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISD-2288: Update tutorial #243

Merged
merged 3 commits into from
Oct 8, 2024
Merged

ISD-2288: Update tutorial #243

merged 3 commits into from
Oct 8, 2024

Conversation

alithethird
Copy link
Contributor

Applicable spec: ISD-2288 (internal)

Overview

Updated the tutorial to standardize.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@alithethird alithethird added the documentation Improvements or additions to documentation label Oct 8, 2024
@alithethird alithethird requested a review from a team as a code owner October 8, 2024 06:29
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on the tutorial!

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Test coverage for df4999f

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          557     35    190     34    91%   162, 204-207, 299->302, 414, 473->477, 627, 658, 664, 681-685, 715, 750-751, 811, 820, 924->937, 936, 938, 943-944, 1004, 1024, 1031, 1121, 1130, 1142, 1163, 1172, 1191, 1195, 1224, 1265, 1397, 1419, 1426->1428, 1471->exit, 1483, 1493, 1531
src/cos.py             20      0      0      0   100%
src/exceptions.py      16      1      2      1    89%   41
src/state.py           33      0      4      0   100%
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 641     36    196     35    92%

Static code analysis report

Run started:2024-10-08 11:03:35.837674

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4647
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@alithethird alithethird merged commit 68915b6 into main Oct 8, 2024
31 checks passed
@alithethird alithethird deleted the tutorial-update branch October 8, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants