Fix map marker background color #206
Conversation
WalkthroughThis pull request introduces enhancements to the map and calendar functionality within the application. The changes primarily focus on improving marker generation, map styling, and dark mode responsiveness. A new Changes
Possibly Related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
👮 Files not reviewed due to content moderation or server errors (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/lib/ui/flow/home/map/map_screen.dart (1)
341-342: Consider using consistent color selection logic.For better consistency, consider using the same color selection logic as in
_observeReloadMarker:- context, next.values.toList(), context.colorScheme.textPrimary, + context, next.values.toList(), + (state.isDarMode) ? Colors.white : Colors.black,app/lib/ui/flow/home/map/map_view_model.dart (1)
442-444: Add documentation for the reloadMarker method.Consider adding documentation to explain the purpose and usage of this method:
+ /// Updates the dark mode state and triggers marker reload + /// @param isDarkMode true if dark mode is enabled, false otherwise void reloadMarker(bool isDarkMode) { state = state.copyWith(isDarMode: isDarkMode); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
app/pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
app/lib/ui/flow/home/map/components/marker_generator.dart(2 hunks)app/lib/ui/flow/home/map/map_screen.dart(4 hunks)app/lib/ui/flow/home/map/map_view_model.dart(4 hunks)app/lib/ui/flow/home/map/map_view_model.freezed.dart(13 hunks)app/lib/ui/flow/journey/calender/horizontal_calendar_view.dart(1 hunks)
🔇 Additional comments (7)
app/lib/ui/flow/home/map/components/marker_generator.dart (1)
15-16: LGTM! Clean implementation of marker color handling.The addition of the
markerColorparameter and the updated color selection logic effectively supports dynamic marker colors while maintaining consistent highlighting for selected markers.Also applies to: 25-26
app/lib/ui/flow/journey/calender/horizontal_calendar_view.dart (1)
78-80: Review date boundary handling logic.The introduction of
groupCreatedDateby subtracting one day fromallowedAfterDatecould lead to unexpected behavior around date boundaries. Additionally, this change seems unrelated to the PR's stated objectives of fixing map marker colors and dark mode support.Could you clarify the reasoning behind this date calculation change? If it's addressing a specific issue, we should add tests to verify the behavior around date boundaries.
app/lib/ui/flow/home/map/map_screen.dart (2)
49-63: LGTM! Well-implemented platform brightness detection.The initialization and platform brightness change listener are properly implemented, ensuring the map style and markers update correctly when the system theme changes.
305-321: LGTM! Clean implementation of marker reloading.The
_observeReloadMarkermethod effectively handles marker updates when dark mode changes, with proper cleanup and state management.app/lib/ui/flow/home/map/map_view_model.dart (2)
465-465: LGTM! Proper state management for dark mode.The
isDarModestate property is correctly initialized and integrated into the state management system.
279-279: LGTM! Improved null safety in showMemberDetail.The update to use optional chaining improves the null safety of the code.
app/lib/ui/flow/home/map/map_view_model.freezed.dart (1)
Line range hint
1-700: Reminder: Do not modify generated files directly.This is an auto-generated file by the Freezed package. Any changes should be made in the source file
map_view_model.dartinstead of modifying this file directly.Run this script to locate the source file:
✅ Verification successful
Do not modify generated files directly
The file
map_view_model.freezed.dartis auto-generated by the Freezed package. Any changes should be made in the source file atapp/lib/ui/flow/home/map/map_view_model.dartinstead.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Find the source file that generates this freezed file fd --type f "map_view_model.dart" --exclude "*.freezed.dart" --exclude "*.g.dart"Length of output: 192
onPlatformBrightnessChangedin map screeninitStatethis callback is called every time on brightness changes.Fix.marker.color.webm
Summary by CodeRabbit
New Features
Bug Fixes
Refactor