Allow sending info.json XHR with Authorization header #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/edu/illinois/library/cantaloupe/source/HttpSource.java # src/main/java/edu/illinois/library/cantaloupe/source/OkHttpHTTPImageInputStreamClient.java
# Conflicts: # CHANGES.md # pom.xml
# Conflicts: # src/test/java/edu/illinois/library/cantaloupe/resource/iiif/v1/InformationResourceTest.java # src/test/java/edu/illinois/library/cantaloupe/resource/iiif/v2/InformationResourceTest.java # src/test/java/edu/illinois/library/cantaloupe/resource/iiif/v3/InformationResourceTest.java
…and setCompletelyWritten() to complete()
…plete() and setCompletelyWritten() to complete()" This reverts commit 0e186d7.
…and setCompletelyWritten() to setComplete()
# Conflicts: # CHANGES.md # pom.xml
# Conflicts: # .gitignore
# Conflicts: # CHANGES.md
…s-builds Attempt moving over to the newer `docker compose`.
If they failed to read the number of bytes, the return of `-1` would cause infinite loops, with `-1` always less than the minimum `offset` of `0`.
…d-reads Fix/wrapped reads
ISSUE-593: Fix Virtual Cropping detection condition to take both Y and X in account
Previously the S3 source would eagerly connect to S3 retrieve information about the object being requested when creating a stream. This change defers retrieval of properties from S3 until needed by the S3StreamFactory, and allows cached files to be served directly from disk with no intermediate S3 lookups.
Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.76 to 1.78. - [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html) - [Commits](https://github.com/bcgit/bc-java/commits) --- updated-dependencies: - dependency-name: org.bouncycastle:bcprov-jdk18on dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…endabot/maven/org.bouncycastle-bcprov-jdk18on-1.78 Bump org.bouncycastle:bcprov-jdk18on from 1.76 to 1.78
Bumps org.eclipse.jetty.http2:http2-server from 11.0.5 to 11.0.17. --- updated-dependencies: - dependency-name: org.eclipse.jetty.http2:http2-server dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…endabot/maven/org.eclipse.jetty.http2-http2-server-11.0.17 Bump org.eclipse.jetty.http2:http2-server from 11.0.5 to 11.0.17
…_pdf_test Adding failing test to check if the fix for PDF is working
…ust-ci Adjust settings for ci builds
Avoid communicating with S3 unless necessary
…yne-patch-1 Upgrade to actions/checkout@v4
…njdk17lts Test with OpenJDK 17 & 21 (LTS)
ksclarke
force-pushed
the
bugfix/xhr-allow-authorization-header
branch
from
a0ee9ef
to
768b4c0
Compare
…ject#574) Web browser clients implementing IIIF Authentication API 1.0 may send info.json requests with an Authorization header via XMLHttpRequest (XHR). Such requests are "pre-flighted", and the pre-flight response must explicitly state that the Authorization header is allowed in order for the browser to proceed with the request.
ksclarke
force-pushed
the
bugfix/xhr-allow-authorization-header
branch
from
95a1277
to
c3a6e9a
Compare
|
Closing this PR because it's been retargeted to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574.