Add missing WebIdentityTokenFileCredentialsProvider for S3ClientBuilder to allow use within EKS IRSA scenario #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to allow use within EKS IRSA scenario
|
This looks like a great addition. Thanks for the contribution! |
|
Closing in favour of #638 which applise the change to the develop branch. |
|
@glenrobson your comment references this issue. Could you reference the correct issue so we can access it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #637
I'm not a Java developer, so I'm not sure if this is right in any way, other than we do build with this patch and run it in production successfully. I welcome anything I can do to make this acceptable.