Add user configurability for file extensions and watched file path #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to use this extension for my project, but our team declares our graphql directly inside of our `ts` or `tsx` files. so i'd like to add a couple settings to allow this: - `"graphql-codegen.fileExtensionsDeclaringGraphQLDocuments"`: change which file extensions are watched for saves. currently this is hardcoded to `graphql` and `gql`. - `"graphql-codegen.filePathToListen"`: allow users to specify a file path that files should match before running codegen. this is important as users could specify a more broad file (eg `ts`) that could exist in both paths relevant to graphql generation and paths that are not.
- read from the workspace config - find some extension match - match the pattern using `multimatch`
- change key name to something better - add markdown description
|
for TS files there would be a better solution though. We can check whether the file has a gql template literal or not and only run codegen when we find it. I'll add this as a config in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @capaj, this extension rocks – really interested in using it for my project, but our team declares our graphql directly inside of our
tsortsxfiles. so i'd like to add a couple settings to allow this:"graphql-codegen.fileExtensionsDeclaringGraphQLDocuments": change which file extensions are watched for saves. currently this is hardcoded tographqlandgql."graphql-codegen.filePathToWatch": allow users to specify a file path that files should match before running codegen. this is important as users could specify a more broad file (egts) that could exist in both paths relevant to graphql generation and paths that are not.