Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node build action #11

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: add node build action #11

merged 2 commits into from
Oct 31, 2024

Conversation

shusak
Copy link
Contributor

@shusak shusak commented Oct 31, 2024

📣 For new features and bugfixes, please create an issue first  

✔️ Checklist

Please review our Contributor Docs for more details


⏩ Next steps:

  • Please ensure that all the automated pipeline steps pass
  • Once your PR is opened, CODEOWNERS will be requested as reviewers. At least one review from a CODEOWNER is required to merge your PR
  • Once approved, a CODEOWNER will merge your changes and perform any other necessary release tasks

@shusak shusak requested a review from a team as a code owner October 31, 2024 18:45
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

erolunal
erolunal previously approved these changes Oct 31, 2024
Copy link
Contributor

@erolunal erolunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commands added to the GH action run successfully locally.

LGTM

Copy link

@wrslatz wrslatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions to consider

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
Copy link

@wrslatz wrslatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other suggestion I forgot

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@erolunal erolunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erolunal erolunal merged commit 69098d4 into capitalone:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to lint/test/build the project
4 participants