-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Hydra's Helper Functions #371
Merged
fdosani
merged 12 commits into
capitalone:develop
from
allyfranken:RCAODF-12933-add-helper-functions
Jan 22, 2025
Merged
Addition of Hydra's Helper Functions #371
fdosani
merged 12 commits into
capitalone:develop
from
allyfranken:RCAODF-12933-add-helper-functions
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyfranken
requested review from
fdosani,
ak-gupta,
jdawang and
gladysteh99
as code owners
January 15, 2025 19:07
fdosani
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial thoughts. I'm going to push some changes to your branch to discuss a bit further.
fdosani
reviewed
Jan 17, 2025
fdosani
reviewed
Jan 17, 2025
fdosani
reviewed
Jan 21, 2025
allyfranken
force-pushed
the
RCAODF-12933-add-helper-functions
branch
2 times, most recently
from
January 22, 2025 15:30
c51636f
to
3eaf760
Compare
allyfranken
force-pushed
the
RCAODF-12933-add-helper-functions
branch
from
January 22, 2025 15:42
3eaf760
to
264fffd
Compare
fdosani
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hydra Team regularly uses datacompy for dataframe comparison. We have added helper functions to the main codebase to allow for additional formatting, control over the compared dataframes, and to capture edge case comparisons.
The major updates in this PR include:
detailed_compare
. When usingdetailed_compare
, if column_to_join is empty, a new column is added to each dataframe called "row_number". Dataframes are then compared based on the row_number instead of a user-provided column.