Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧑‍💻 RFC: Add typed routes using routes-gen #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧑‍💻 RFC: Add typed routes using routes-gen #4

wants to merge 1 commit into from

Conversation

haakonmt
Copy link
Contributor

Hva tenker vi om dette? 🤔 Jeg liker å slippe å tenke på skrivefeil etc. i lenker, men hva føler dere andre?

@netlify
Copy link

netlify bot commented Jun 18, 2022 •
edited
Loading

✅ Deploy Preview for capraconsulting ready!

Name Link
🔨 Latest commit 69fa054
🔍 Latest deploy log https://app.netlify.com/sites/capraconsulting/deploys/62ae100d4ae4cb000928822d
😎 Deploy Preview https://deploy-preview-4--capraconsulting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@juliuxu
Copy link
Contributor

juliuxu commented Jun 18, 2022

Kult! 🤩
Det er en ekstra dependency og logikk å forholde seg til.
Men når det er sakt ser jo det her veldig overkommelig ut! Spesielt med tanke på hva vi får.

Svake koblinger, never again! 👍

cammiida
cammiida approved these changes Jun 19, 2022
View reviewed changes
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette ser deilig ut. Går fint for min del! Om vi finner ut at vi ikke vil ha avhengigheten lenger, er det ikke en stor jobb å fjerne det heller 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammiida cammiida cammiida approved these changes

@juliuxu juliuxu juliuxu approved these changes

@ingridsd ingridsd Awaiting requested review from ingridsd

@terjeruuda terjeruuda Awaiting requested review from terjeruuda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haakonmt @juliuxu @cammiida