fix: [1710] - Ensure querySelector returns the first item that appears in the DOM for grouped selectors #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the DOM for grouped selectors
…s in the DOM for grouped selectors
christiango
commented
Jan 31, 2025
| selector: string, | ||
| cachedItem: ICachedQuerySelectorAllItem | ICachedQuerySelectorItem | ||
| ): void { | ||
| const groups = SelectorParser.getSelectorGroups(selector); |
There was a problem hiding this comment.
My main concerns with this change are the following:
- I'm new to this project so I'm afraid this may have some unexpected consequences due to the complex nature of the caches required to make these perform well
- I'm not sure how much this impacts performance of the library all up, particularly in less complicated query selector scenarios than the one described in the bug.
capricorn86
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Thank you for contributing @christiango! ⭐
I believe that this fix would have a big impact on performance.
I think the best way to solve this bug is to add support for returning DocumentPositionAndElement to findFirst() (similar as what findAll() does). Then querySelector() collects the matches for all groups and sorts them by position (similar to what querySelectorAll() does).
|
Great suggestion, I'll give that a shot! |
…s in the DOM for grouped selectors
…s in the DOM for grouped selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710
Added a test case to query selector that in the current build of happy-dom fails due to it returning the first item that matches the grouped selector instead of the first element in the DOM that matches any selector in the group. This matches the behavior of Chromium browsers as well as JSDOM.