Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toggletip] Update Usage and Style tab #4468

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Feb 13, 2025

Closes #3713 #3714

Changelog

  • States from inactive and active to open and closed
  • Other changes are documented in the issues above
  • Some outdated info like the size of the container in the Usage tab

@thyhmdo thyhmdo requested a review from laurenmrice February 13, 2025 19:56
@thyhmdo thyhmdo requested review from a team as code owners February 13, 2025 19:56

This comment was marked as outdated.

@tay1orjones tay1orjones reopened this Feb 14, 2025

This comment was marked as resolved.

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Deploy preview

✅ Successfully published at https://4468--carbondesignsystem.netlify.app with commit undefined

Logs

Deploys by Netlify

This comment was marked as resolved.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage tab

Related section

Can your remove this last sentence in the Disclosures paragraph?
Screenshot 2025-02-25 at 11 56 45 AM


Style tab

Interactive state color

In this image, I think the last label needs to say "Toggletip open (focus)"? I also now wonder if the image next to it is representing the hover, so it should be "Toggletip open (hover)" and have the hand cursor?

Screenshot 2025-02-25 at 11 59 19 AM

If that is true, I think that both the Closed and Open Hover/Focus states should be covered in the table, something like this.
Screenshot 2025-02-25 at 12 13 58 PM

Structure

  • I don't think you need the Toggletip heading anymore here, and you can remove the part where it talks about "Types" and change the word "tooltips" to "toggletips".
  • In the structure image I would say "concise" instead of "precise".
Screenshot 2025-02-25 at 12 15 40 PM

Feedback

Not sure if you can see this on your end in vscode and remove it, but there is a "Show less" text bug under the Feedback section.

Screenshot 2025-02-25 at 12 18 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggletip: Usage tab
4 participants