-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toggletip] Update Usage and Style tab #4468
base: main
Are you sure you want to change the base?
[Toggletip] Update Usage and Style tab #4468
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Deploy preview✅ Successfully published at https://4468--carbondesignsystem.netlify.app with commit undefined |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage tab
Related section
Can your remove this last sentence in the Disclosures paragraph?
Style tab
Interactive state color
In this image, I think the last label needs to say "Toggletip open (focus)"? I also now wonder if the image next to it is representing the hover, so it should be "Toggletip open (hover)" and have the hand cursor?

If that is true, I think that both the Closed and Open Hover/Focus states should be covered in the table, something like this.
Structure
- I don't think you need the Toggletip heading anymore here, and you can remove the part where it talks about "Types" and change the word "tooltips" to "toggletips".
- In the structure image I would say "concise" instead of "precise".

Feedback
Not sure if you can see this on your end in vscode and remove it, but there is a "Show less" text bug under the Feedback section.

Closes #3713 #3714
Changelog