Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(list): Update the Style tab with the latest content template #4477

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

doc(list): Update the Style tab with the latest content template #4477

wants to merge 10 commits into from
+37 −12

Conversation

Kritvi-bhatia17
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 commented Feb 19, 2025 •
edited
Loading

Closes #4424

Update the Style tab with the latest content template and fixed a few more sections.

Changelog

New

  • Added a few sections:
    • Description
    • Anchor links
    • Feedback

Changed

  • Updated the order of the list's variants in all sections (text & image): Start with Unordered first, then Ordered
  • Updated a few images

@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners February 19, 2025 12:56
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 5:11pm

@laurenmrice
Copy link
Member

@guidari When you get a chance, can you fix the deploy preview? Thank you!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

Deploy preview successfully published at https://4477--carbondesignsystem.netlify.app with commit (325a164)

@laurenmrice laurenmrice removed the request for review from sunny-babbar February 21, 2025 20:29
laurenmrice
laurenmrice requested changes Feb 21, 2025
View reviewed changes
@laurenmrice
Copy link
Member

@Kritvi-bhatia17 The only other thing I see is that the structure image in the figma file needs to be 736px wide instead of 608px because it uses the fixed image component. Then it should render properly.

@Kritvi-bhatia17
Copy link
Contributor Author

@Kritvi-bhatia17 The only other thing I see is that the structure image in the figma file needs to be 736px wide instead of 608px because it uses the fixed image component. Then it should render properly.

Oh, I have fixed that @laurenmrice

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @kenny or @guidari, can you please review this PR, whenever you get some time. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List: Style tab
4 participants
@Kritvi-bhatia17 @laurenmrice @tay1orjones @alina-jacob