Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tile): web component parity #18514

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #18349

Tile parity work

Changelog

Changed

  • clean up stories to match react ( only showing disable prop or hasRoundedCorners )
    • the children, ai-label/decorator can be added through a slot so not applicable to be added as a control since it's not a prop
  • deprecate color-scheme
  • use the imported ai-label icon
  • selectable-tile no longer uses input inside but instead a div
  • update keydown and click functions to ensure proper functionality when tabbing/clicking through tile components
  • added some additional styling

Testing / Reviewing

go to Tile stories and compare each story with react

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d0024b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67a63c74b5cf020008ad843b
😎 Deploy Preview https://deploy-preview-18514--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d0024b2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67a63c748e4d520008cfea7f
😎 Deploy Preview https://deploy-preview-18514--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d0024b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67a63c74e495c700081f4424
😎 Deploy Preview https://deploy-preview-18514--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (3fdfa27) to head (d0024b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18514   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         408      408           
  Lines       14474    14474           
  Branches     4664     4684   +20     
=======================================
  Hits        12166    12166           
+ Misses       2142     2141    -1     
- Partials      166      167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 4, 2025 21:42
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner February 4, 2025 21:42
@alisonjoseph alisonjoseph requested review from a team and Kritvi-bhatia17 and removed request for a team February 7, 2025 14:18
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things, otherwise LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Tile
2 participants