-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tile): web component parity #18514
base: main
Are you sure you want to change the base?
chore(tile): web component parity #18514
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18514 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 408 408
Lines 14474 14474
Branches 4664 4684 +20
=======================================
Hits 12166 12166
+ Misses 2142 2141 -1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things, otherwise LGTM!
Co-authored-by: kennylam <[email protected]>
Closes #18349
Tile parity work
Changelog
Changed
disable
prop orhasRoundedCorners
)input
inside but instead adiv
Testing / Reviewing
go to Tile stories and compare each story with react