fix: full page story with global header #4794
Merged
+287
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for carbon-for-ibm-products failed.
|
| @@ -21,8 +21,15 @@ | |||
| $block-class: #{c4p-settings.$pkg-prefix}--create-full-page; | |||
| $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step; | |||
|
|
|||
| .#{$block-class} .#{$block-class} { | |||
| .#{$block-class}.#{$block-class} { | |||
There was a problem hiding this comment.
Duplicate class names?
There was a problem hiding this comment.
@paul-balchin-ibm I didn't add the duplicate names, just made them functional assuming they were supposed to.
Removed the duplicate.
lee-chase
changed the title
davidmenendez
approved these changes
Apr 15, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 16, 2024
af77a38
11 of 15 checks passed
|
I think this change introduced this issue: |
| color: var(--cds-text-primary, #161616); | ||
| grid-template-rows: minmax(auto, 100%); |
There was a problem hiding this comment.
Hello @lee-chase
This doesn't work on some browsers which causes some height issues as you can see from the screenshot.
There was a problem hiding this comment.
Please take a look at this PR:
#5993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A global header does not work with full page create
What did you change?
E.g.
How did you test and verify your work?
Storybook
Next
May need to raise issue for other full page e.g. edit?